github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #956 from progrium/mh-comment-out-skipped-unit-tests

Browse Source 
comment out skipped tests as we pay the cost for setup() and teardown() anyway
This commit is contained in:
Michael Hobbs
2015-02-07 14:38:18 -08:00
parent c4ef29173c a9c1ed0c6d
commit 7af7355441
2 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/unit/client.bats
View File

@@ -113,17 +113,17 @@ teardown() {
assert_success assert_success
} }
@test "dokku client (ps)" { # @test "dokku client (ps)" {
# CI support: 'Ah. I just spoke with our Docker expert -- # # CI support: 'Ah. I just spoke with our Docker expert --
# looks like docker exec is built to work with docker-under-libcontainer, # # looks like docker exec is built to work with docker-under-libcontainer,
# but we're using docker-under-lxc. I don't have an estimated time for the fix, sorry # # but we're using docker-under-lxc. I don't have an estimated time for the fix, sorry
skip "circleci does not support docker exec at the moment." # skip "circleci does not support docker exec at the moment."
deploy_app # deploy_app
run bash -c "${BATS_TEST_DIRNAME}/../../contrib/dokku_client.sh ps $TEST_APP | grep -q 'node web.js'" # run bash -c "${BATS_TEST_DIRNAME}/../../contrib/dokku_client.sh ps $TEST_APP | grep -q 'node web.js'"
echo "output: "$output # echo "output: "$output
echo "status: "$status # echo "status: "$status
assert_success # assert_success
} # }
@test "dokku client (ps:start)" { @test "dokku client (ps:start)" {
deploy_app deploy_app

20
tests/unit/ps.bats
View File

@@ -10,16 +10,16 @@ teardown() {
destroy_app destroy_app
} }
@test "ps" { # @test "ps" {
# CI support: 'Ah. I just spoke with our Docker expert -- # # CI support: 'Ah. I just spoke with our Docker expert --
# looks like docker exec is built to work with docker-under-libcontainer, # # looks like docker exec is built to work with docker-under-libcontainer,
# but we're using docker-under-lxc. I don't have an estimated time for the fix, sorry # # but we're using docker-under-lxc. I don't have an estimated time for the fix, sorry
skip "circleci does not support docker exec at the moment." # skip "circleci does not support docker exec at the moment."
run bash -c "dokku ps $TEST_APP | grep -q \"node web.js\"" # run bash -c "dokku ps $TEST_APP | grep -q \"node web.js\""
echo "output: "$output # echo "output: "$output
echo "status: "$status # echo "status: "$status
assert_success # assert_success
} # }
@test "ps:start" { @test "ps:start" {
run bash -c "dokku ps:stop $TEST_APP" run bash -c "dokku ps:stop $TEST_APP"