refactor: deprecate the --rm and --rm-container flags

These flags are not commonly invoked by users, causing issues when cleaning up old containers. Rather than instruct users to use some random flag, just change the default to what is likely to be more common.

tests/unit/app-json-2.bats

@@ -60,7 +60,7 @@ teardown() {
   assert_output_contains "entrypoint script started with arguments touch /app/predeploy.test"
   assert_success
 
-  run /bin/bash -c "dokku --rm run $TEST_APP ls /app/predeploy.test"
+  run /bin/bash -c "dokku run $TEST_APP ls /app/predeploy.test"
   echo "output: $output"
   echo "status: $status"
   assert_success

tests/unit/app-json.bats

@@ -31,12 +31,12 @@ teardown() {
   assert_success
   assert_output '["/start","web"]'
 
-  run /bin/bash -c "dokku --rm run $TEST_APP ls /app/prebuild.test"
+  run /bin/bash -c "dokku run $TEST_APP ls /app/prebuild.test"
   echo "output: $output"
   echo "status: $status"
   assert_failure
 
-  run /bin/bash -c "dokku --rm run $TEST_APP ls /app/predeploy.test"
+  run /bin/bash -c "dokku run $TEST_APP ls /app/predeploy.test"
   echo "output: $output"
   echo "status: $status"
   assert_success

tests/unit/core_1.bats

@@ -11,7 +11,6 @@ setup() {
 teardown() {
   rm -rf /home/dokku/$TEST_APP/tls
   destroy_app
-  dokku config:unset --global DOKKU_RM_CONTAINER
   rm -f "$DOCKERFILE"
   global_teardown
 }

tests/unit/ps-general.bats

@@ -175,24 +175,24 @@ EOF
   assert_success
   assert_output "true"
 
-  run /bin/bash -c "dokku --rm run $TEST_APP console"
+  run /bin/bash -c "dokku run $TEST_APP console"
   echo "output: $output"
   echo "status: $status"
   assert_success
   assert_output_contains "Hello world!"
 
-  run /bin/bash -c "dokku --rm run $TEST_APP printenv FOO"
+  run /bin/bash -c "dokku run $TEST_APP printenv FOO"
   echo "output: $output"
   echo "status: $status"
   assert_failure
 
-  run /bin/bash -c "dokku --rm config:set $TEST_APP FOO=bar"
+  run /bin/bash -c "dokku config:set $TEST_APP FOO=bar"
   echo "output: $output"
   echo "status: $status"
   assert_success
   assert_output_contains "Releasing $TEST_APP"
 
-  run /bin/bash -c "dokku --rm run $TEST_APP printenv FOO"
+  run /bin/bash -c "dokku run $TEST_APP printenv FOO"
   echo "output: $output"
   echo "status: $status"
   assert_success

tests/unit/run_1.bats

@@ -9,7 +9,6 @@ setup() {
 
 teardown() {
   destroy_app
-  dokku config:unset --global DOKKU_RM_CONTAINER
   global_teardown
 }
 

tests/unit/run_2.bats

@@ -9,59 +9,21 @@ setup() {
 
 teardown() {
   destroy_app
-  dokku config:unset --global DOKKU_RM_CONTAINER
   global_teardown
 }
 
-@test "(core) run (with DOKKU_RM_CONTAINER/--rm-container)" {
+@test "(core) run" {
   deploy_app
 
-  run /bin/bash -c "dokku --rm-container run $TEST_APP echo $TEST_APP"
+  run /bin/bash -c "dokku run $TEST_APP echo $TEST_APP"
   echo "output: $output"
   echo "status: $status"
   assert_success
+
   run /bin/bash -c "docker ps -a -f 'status=exited' --no-trunc=true | grep \"/exec echo $TEST_APP\""
   echo "output: $output"
   echo "status: $status"
   assert_failure
-
-  run /bin/bash -c "dokku config:set --no-restart $TEST_APP DOKKU_RM_CONTAINER=1"
-  echo "output: $output"
-  echo "status: $status"
-  assert_success
-
-  run /bin/bash -c "dokku --rm-container run $TEST_APP echo $TEST_APP"
-  echo "output: $output"
-  echo "status: $status"
-  assert_success
-  run /bin/bash -c "docker ps -a -f 'status=exited' --no-trunc=true | grep \"/exec echo $TEST_APP\""
-  echo "output: $output"
-  echo "status: $status"
-  assert_failure
-
-  run /bin/bash -c "dokku config:unset --no-restart $TEST_APP DOKKU_RM_CONTAINER"
-  echo "output: $output"
-  echo "status: $status"
-  assert_success
-
-  run /bin/bash -c "dokku config:set --global DOKKU_RM_CONTAINER=1"
-  echo "output: $output"
-  echo "status: $status"
-  assert_success
-
-  run /bin/bash -c "dokku --rm-container run $TEST_APP echo $TEST_APP"
-  echo "output: $output"
-  echo "status: $status"
-  assert_success
-  run /bin/bash -c "docker ps -a -f 'status=exited' --no-trunc=true | grep \"/exec echo $TEST_APP\""
-  echo "output: $output"
-  echo "status: $status"
-  assert_failure
-
-  run /bin/bash -c "dokku config:unset --global DOKKU_RM_CONTAINER"
-  echo "output: $output"
-  echo "status: $status"
-  assert_success
 }
 
 @test "(core) run (detached)" {