refactor: deprecate the --rm and --rm-container flags

These flags are not commonly invoked by users, causing issues when cleaning up old containers. Rather than instruct users to use some random flag, just change the default to what is likely to be more common.

plugins/common/functions

@@ -439,7 +439,7 @@ parse_args() {
         export DOKKU_TRACE=1
         ;;
       --rm-container | --rm)
-        export DOKKU_RM_CONTAINER=1
+        dokku_log_warn_quiet "Deprecated: all run containers are now removed on exit by default"
         ;;
       --force)
         export DOKKU_APPS_FORCE_DELETE=1

plugins/cron/functions.go

@@ -33,7 +33,7 @@ func (t templateCommand) CronCommand() string {
 		return t.AltCommand
 	}
 
-	return fmt.Sprintf("dokku --rm run --cron-id %s %s %s", t.ID, t.App, t.Command)
+	return fmt.Sprintf("dokku run --cron-id %s %s %s", t.ID, t.App, t.Command)
 }
 
 func fetchCronEntries(appName string) ([]templateCommand, error) {

plugins/run/internal-functions

@@ -57,5 +57,6 @@ cmd-run() {
   declare cmd="run"
   [[ "$1" == "$cmd" ]] && shift 1
 
+  export DOKKU_RM_CONTAINER=1
   fn-run "$@"
 }