feat: use container name instead of container id for run:detached output
Closes #5170
This commit is contained in:
1 parent
a4554b794e
commit
60acf68412
3 files changed
+7
-1
No files matched your search
@@ -0,0 +1,5 @@
|
|||||||
|
# 0.29.0 Migration Guide
|
||||||
|
|
||||||
|
## Changes
|
||||||
|
|
||||||
|
The output of `run:detached` now uses the container name - eg. `node-js-app.run.1` - vs the container id.
|
||||||
@@ -18,6 +18,7 @@ Docker releases updates periodically to their engine. We recommend reading their
|
|||||||
|
|
||||||
Before upgrading, check the migration guides to get comfortable with new features and prepare your deployment to be upgraded.
|
Before upgrading, check the migration guides to get comfortable with new features and prepare your deployment to be upgraded.
|
||||||
|
|
||||||
|
- [Upgrading to 0.29](/docs/appendices/0.29.0-migration-guide.md)
|
||||||
- [Upgrading to 0.28](/docs/appendices/0.28.0-migration-guide.md)
|
- [Upgrading to 0.28](/docs/appendices/0.28.0-migration-guide.md)
|
||||||
- [Upgrading to 0.27](/docs/appendices/0.27.0-migration-guide.md)
|
- [Upgrading to 0.27](/docs/appendices/0.27.0-migration-guide.md)
|
||||||
- [Upgrading to 0.26](/docs/appendices/0.26.0-migration-guide.md)
|
- [Upgrading to 0.26](/docs/appendices/0.26.0-migration-guide.md)
|
||||||
|
|||||||
@@ -122,7 +122,7 @@ trigger-scheduler-docker-local-scheduler-run() {
|
|||||||
local EXIT_CODE=0 DOKKU_CONTAINER_EXIT_CODE=0
|
local EXIT_CODE=0 DOKKU_CONTAINER_EXIT_CODE=0
|
||||||
if [[ "$DOKKU_DETACH_CONTAINER" == "1" ]]; then
|
if [[ "$DOKKU_DETACH_CONTAINER" == "1" ]]; then
|
||||||
"$DOCKER_BIN" container start "${DOCKER_START_ARGS_ARRAY[@]}" "$CONTAINER_ID" >/dev/null || DOKKU_CONTAINER_EXIT_CODE=$?
|
"$DOCKER_BIN" container start "${DOCKER_START_ARGS_ARRAY[@]}" "$CONTAINER_ID" >/dev/null || DOKKU_CONTAINER_EXIT_CODE=$?
|
||||||
echo "$CONTAINER_ID"
|
"$DOCKER_BIN" container inspect --format "{{.Name}}" "$CONTAINER_ID" | cut -c2-
|
||||||
else
|
else
|
||||||
"$DOCKER_BIN" container start "${DOCKER_START_ARGS_ARRAY[@]}" "$CONTAINER_ID" || EXIT_CODE=$?
|
"$DOCKER_BIN" container start "${DOCKER_START_ARGS_ARRAY[@]}" "$CONTAINER_ID" || EXIT_CODE=$?
|
||||||
DOKKU_CONTAINER_EXIT_CODE="$("$DOCKER_BIN" container wait "$CONTAINER_ID" 2>/dev/null || echo "$EXIT_CODE")"
|
DOKKU_CONTAINER_EXIT_CODE="$("$DOCKER_BIN" container wait "$CONTAINER_ID" 2>/dev/null || echo "$EXIT_CODE")"
|
||||||
|
|||||||
Reference in new issue
Block a user