test: use BATS_TEST_TMPDIR in core-post-extract regression tests
The previous form set `trap "rm -rf '$TMP_DIR'" RETURN` inside the test, but bats propagates `RETURN` traps to nested function calls, so the trap fired on the first `assert_success` and removed the work directory before the trigger script ran. Switching to bats's per-test `BATS_TEST_TMPDIR` removes the trap entirely and lets bats handle cleanup.
This commit is contained in:
5 files changed
+20
-35
No files matched your search
@@ -143,25 +143,22 @@ teardown() {
|
||||
}
|
||||
|
||||
@test "(builder-railpack) core-post-extract renames the configured railpack.json" {
|
||||
local TMP_DIR
|
||||
TMP_DIR="$(mktemp -d "/tmp/dokku-test-builder-railpack.XXXXXX")"
|
||||
trap "rm -rf '$TMP_DIR'" RETURN
|
||||
echo "{}" >"$TMP_DIR/railpack.alt.json"
|
||||
echo "{}" >"$BATS_TEST_TMPDIR/railpack.alt.json"
|
||||
|
||||
run /bin/bash -c "dokku builder-railpack:set $TEST_APP railpackjson-path railpack.alt.json"
|
||||
echo "output: $output"
|
||||
echo "status: $status"
|
||||
assert_success
|
||||
|
||||
run_plugin_script builder-railpack core-post-extract "$TEST_APP" "$TMP_DIR" HEAD
|
||||
run_plugin_script builder-railpack core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD
|
||||
echo "output: $output"
|
||||
echo "status: $status"
|
||||
assert_success
|
||||
|
||||
run /bin/bash -c "test -f $TMP_DIR/railpack.json"
|
||||
run /bin/bash -c "test -f $BATS_TEST_TMPDIR/railpack.json"
|
||||
assert_success
|
||||
|
||||
run /bin/bash -c "test ! -e $TMP_DIR/railpack.alt.json"
|
||||
run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/railpack.alt.json"
|
||||
assert_success
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user