test: use BATS_TEST_TMPDIR in core-post-extract regression tests

The previous form set `trap "rm -rf '$TMP_DIR'" RETURN` inside the test, but bats propagates `RETURN` traps to nested function calls, so the trap fired on the first `assert_success` and removed the work directory before the trigger script ran. Switching to bats's per-test `BATS_TEST_TMPDIR` removes the trap entirely and lets bats handle cleanup.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-08 01:34:05 -04:00
parent bc8adfa6e2
commit 5d212f3195
5 changed files with 20 additions and 35 deletions

View File

@@ -229,25 +229,22 @@ teardown() {
}
@test "(builder-pack) core-post-extract renames the configured project.toml" {
local TMP_DIR
TMP_DIR="$(mktemp -d "/tmp/dokku-test-builder-pack.XXXXXX")"
trap "rm -rf '$TMP_DIR'" RETURN
echo "" >"$TMP_DIR/project2.toml"
echo "" >"$BATS_TEST_TMPDIR/project2.toml"
run /bin/bash -c "dokku builder-pack:set $TEST_APP projecttoml-path project2.toml"
echo "output: $output"
echo "status: $status"
assert_success
run_plugin_script builder-pack core-post-extract "$TEST_APP" "$TMP_DIR" HEAD
run_plugin_script builder-pack core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "test -f $TMP_DIR/project.toml"
run /bin/bash -c "test -f $BATS_TEST_TMPDIR/project.toml"
assert_success
run /bin/bash -c "test ! -e $TMP_DIR/project2.toml"
run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/project2.toml"
assert_success
}