github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

test: use BATS_TEST_TMPDIR in core-post-extract regression tests

Browse Source 
The previous form set `trap "rm -rf '$TMP_DIR'" RETURN` inside the test, but bats propagates `RETURN` traps to nested function calls, so the trap fired on the first `assert_success` and removed the work directory before the trigger script ran. Switching to bats's per-test `BATS_TEST_TMPDIR` removes the trap entirely and lets bats handle cleanup.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-08 01:34:05 -04:00
parent bc8adfa6e2
commit 5d212f3195
5 changed files with 20 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/builder-dockerfile.bats
View File

@@ -156,25 +156,22 @@ EOF
}
@test "(builder-dockerfile) core-post-extract renames the configured dockerfile" {
local TMP_DIR
TMP_DIR="$(mktemp -d "/tmp/dokku-test-builder-dockerfile.XXXXXX")"
trap "rm -rf '$TMP_DIR'" RETURN
echo "FROM scratch" >"$TMP_DIR/second.Dockerfile"
echo "FROM scratch" >"$BATS_TEST_TMPDIR/second.Dockerfile"
run /bin/bash -c "dokku builder-dockerfile:set $TEST_APP dockerfile-path second.Dockerfile"
echo "output: $output"
echo "status: $status"
assert_success
run_plugin_script builder-dockerfile core-post-extract "$TEST_APP" "$TMP_DIR" HEAD
run_plugin_script builder-dockerfile core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "test -f $TMP_DIR/Dockerfile"
run /bin/bash -c "test -f $BATS_TEST_TMPDIR/Dockerfile"
assert_success
run /bin/bash -c "test ! -e $TMP_DIR/second.Dockerfile"
run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/second.Dockerfile"
assert_success
}