fix(caddy-vhosts): treat is_app_listening as a boolean, not a non-empty string
The docker-args-process-deploy trigger initialized is_app_listening to the string "false" and then tested it with [[ -n ... ]], which is always true. Apps with domains, tls-internal, and no http/https port mapping got a stray caddy.tls=internal label. Fixes #8973
This commit is contained in:
1 parent
667abddd13
commit
50a90cade1
2 files changed
+133
-1
No files matched your search
@@ -86,7 +86,7 @@ trigger-caddy-vhosts-docker-args-process-deploy() {
|
||||
|
||||
# add the labels for caddy here
|
||||
# prefer the https:443 mapping to http:80 mapping
|
||||
if [[ -n "$is_app_listening" ]] && [[ -n "$caddy_domains" ]]; then
|
||||
if [[ "$is_app_listening" == "true" ]] && [[ -n "$caddy_domains" ]]; then
|
||||
has_443_mapping=false
|
||||
tls_internal="$(fn-caddy-computed-tls-internal "$APP")"
|
||||
if [[ -n "$proxy_container_https_port" ]] || [[ -n "$proxy_container_https_port_candidate" ]]; then
|
||||
|
||||
Reference in new issue
Block a user