fix: do not allow slashes in app names
There is likely a better regex for the actually allowed names, but this will suffice for ensuring folks don't do weird things with their folder structures... Closes #4013
This commit is contained in:
1 parent
46d4de261c
commit
4aae0f1a1d
2 files changed
+6
-1
No files matched your search
@@ -582,7 +582,7 @@ func IsValidAppName(appName string) error {
|
|||||||
return fmt.Errorf("APP must not be null")
|
return fmt.Errorf("APP must not be null")
|
||||||
}
|
}
|
||||||
|
|
||||||
r, _ := regexp.Compile("^[a-z0-9][^:A-Z]*$")
|
r, _ := regexp.Compile("^[a-z0-9][^/:A-Z]*$")
|
||||||
if r.MatchString(appName) {
|
if r.MatchString(appName) {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -81,6 +81,11 @@ teardown() {
|
|||||||
echo "status: $status"
|
echo "status: $status"
|
||||||
assert_failure
|
assert_failure
|
||||||
|
|
||||||
|
run /bin/bash -c "dokku apps:create test/app"
|
||||||
|
echo "output: $output"
|
||||||
|
echo "status: $status"
|
||||||
|
assert_failure
|
||||||
|
|
||||||
run /bin/bash -c "dokku --app $TEST_APP apps:create"
|
run /bin/bash -c "dokku --app $TEST_APP apps:create"
|
||||||
echo "output: $output"
|
echo "output: $output"
|
||||||
echo "status: $status"
|
echo "status: $status"
|
||||||
|
|||||||
Reference in new issue
Block a user