diff --git a/plugins/domains/core-post-deploy b/plugins/domains/core-post-deploy index d564a6ce6..60b71ef6f 100755 --- a/plugins/domains/core-post-deploy +++ b/plugins/domains/core-post-deploy @@ -25,7 +25,7 @@ trigger-domains-core-post-deploy() { fi if [[ "$domain" =~ $RE_IPV6 ]]; then - dokku_log_warn "Detected IPv4 domain name with nginx proxy enabled." + dokku_log_warn "Detected IPv6 domain name with nginx proxy enabled." dokku_log_warn "Ensure the default nginx site is removed before continuing." break fi diff --git a/tests/unit/domains.bats b/tests/unit/domains.bats index f37f88ff4..af8c35efa 100644 --- a/tests/unit/domains.bats +++ b/tests/unit/domains.bats @@ -355,3 +355,21 @@ teardown() { echo "status: $status" assert_success } + +@test "(domains) verify warning on ipv4/ipv6 domain name" { + touch /etc/nginx/sites-enabled/default + rm "$DOKKU_ROOT/VHOST" + echo "127.0.0.1" >"$DOKKU_ROOT/VHOST" + run deploy_app + echo "output: $output" + echo "status: $status" + assert_success + assert_output_contains "Detected IPv4 domain name with nginx proxy enabled." + + rm -f /etc/nginx/sites-enabled/default + run /bin/bash -c "dokku ps:rebuild $TEST_APP" + echo "output: $output" + echo "status: $status" + assert_success + assert_output_contains "Detected IPv4 domain name with nginx proxy enabled." 0 +} \ No newline at end of file