diff --git a/plugins/builder-dockerfile/core-post-extract b/plugins/builder-dockerfile/core-post-extract index 5334e8d3a..15e80c16e 100755 --- a/plugins/builder-dockerfile/core-post-extract +++ b/plugins/builder-dockerfile/core-post-extract @@ -10,7 +10,7 @@ trigger-builder-dockerfile-core-post-extract() { declare APP="$1" SOURCECODE_WORK_DIR="$2" local NEW_DOCKERFILE="$(fn-builder-dockerfile-computed-dockerfile-path "$APP")" - pushd "$TMP_WORK_DIR" >/dev/null + pushd "$SOURCECODE_WORK_DIR" >/dev/null if [[ -z "$NEW_DOCKERFILE" ]]; then return diff --git a/plugins/builder-lambda/core-post-extract b/plugins/builder-lambda/core-post-extract index a7a4b6a39..7d431379a 100755 --- a/plugins/builder-lambda/core-post-extract +++ b/plugins/builder-lambda/core-post-extract @@ -10,7 +10,7 @@ trigger-builder-lambda-core-post-extract() { declare APP="$1" SOURCECODE_WORK_DIR="$2" local NEW_LAMBDA_YML="$(fn-builder-lambda-computed-lambdayml-path "$APP")" - pushd "$TMP_WORK_DIR" >/dev/null + pushd "$SOURCECODE_WORK_DIR" >/dev/null if [[ -z "$NEW_LAMBDA_YML" ]]; then return diff --git a/plugins/builder-nixpacks/core-post-extract b/plugins/builder-nixpacks/core-post-extract index eaaa5dd5e..a3d42a4b2 100755 --- a/plugins/builder-nixpacks/core-post-extract +++ b/plugins/builder-nixpacks/core-post-extract @@ -10,7 +10,7 @@ trigger-builder-nixpacks-core-post-extract() { declare APP="$1" SOURCECODE_WORK_DIR="$2" local NEW_NIXPACKS_YML="$(fn-builder-nixpacks-computed-nixpackstoml-path "$APP")" - pushd "$TMP_WORK_DIR" >/dev/null + pushd "$SOURCECODE_WORK_DIR" >/dev/null if [[ -z "$NEW_NIXPACKS_YML" ]]; then return diff --git a/plugins/builder-pack/core-post-extract b/plugins/builder-pack/core-post-extract index 4c50479e2..381d176f7 100755 --- a/plugins/builder-pack/core-post-extract +++ b/plugins/builder-pack/core-post-extract @@ -10,7 +10,7 @@ trigger-builder-pack-core-post-extract() { declare APP="$1" SOURCECODE_WORK_DIR="$2" local NEW_PROJECT_TOML="$(fn-builder-pack-computed-projecttoml-path "$APP")" - pushd "$TMP_WORK_DIR" >/dev/null + pushd "$SOURCECODE_WORK_DIR" >/dev/null if [[ -z "$NEW_PROJECT_TOML" ]]; then return diff --git a/plugins/builder-railpack/core-post-extract b/plugins/builder-railpack/core-post-extract index ad863c076..d78b8d7da 100755 --- a/plugins/builder-railpack/core-post-extract +++ b/plugins/builder-railpack/core-post-extract @@ -10,7 +10,7 @@ trigger-builder-railpack-core-post-extract() { declare APP="$1" SOURCECODE_WORK_DIR="$2" local NEW_RAILPACK_JSON="$(fn-builder-railpack-computed-railpackjson-path "$APP")" - pushd "$TMP_WORK_DIR" >/dev/null + pushd "$SOURCECODE_WORK_DIR" >/dev/null if [[ -z "$NEW_RAILPACK_JSON" ]]; then return diff --git a/tests/unit/builder-dockerfile.bats b/tests/unit/builder-dockerfile.bats index 794c31ca9..d6d9b682d 100644 --- a/tests/unit/builder-dockerfile.bats +++ b/tests/unit/builder-dockerfile.bats @@ -155,6 +155,26 @@ EOF assert_output "3001/udp 3000/tcp 3003" } +@test "(builder-dockerfile) core-post-extract renames the configured dockerfile" { + echo "FROM scratch" >"$BATS_TEST_TMPDIR/second.Dockerfile" + + run /bin/bash -c "dokku builder-dockerfile:set $TEST_APP dockerfile-path second.Dockerfile" + echo "output: $output" + echo "status: $status" + assert_success + + run_plugin_script builder-dockerfile core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "test -f $BATS_TEST_TMPDIR/Dockerfile" + assert_success + + run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/second.Dockerfile" + assert_success +} + @test "(builder-dockerfile) ps:rebuild fetches files from image" { run /bin/bash -c "dokku --trace git:from-image $TEST_APP dokku/smoke-test-app:dockerfile" echo "output: $output" diff --git a/tests/unit/builder-lambda.bats b/tests/unit/builder-lambda.bats index 160e28b69..e2c0933b5 100644 --- a/tests/unit/builder-lambda.bats +++ b/tests/unit/builder-lambda.bats @@ -152,6 +152,26 @@ teardown() { assert_success } +@test "(builder-lambda) core-post-extract renames the configured lambda.yml" { + echo "---" >"$BATS_TEST_TMPDIR/lambda2.yml" + + run /bin/bash -c "dokku builder-lambda:set $TEST_APP lambdayml-path lambda2.yml" + echo "output: $output" + echo "status: $status" + assert_success + + run_plugin_script builder-lambda core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "test -f $BATS_TEST_TMPDIR/lambda.yml" + assert_success + + run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/lambda2.yml" + assert_success +} + inject_lambda_yml() { local APP="$1" local APP_REPO_DIR="$2" diff --git a/tests/unit/builder-nixpacks.bats b/tests/unit/builder-nixpacks.bats index ecdd7d59a..56f4cf20f 100644 --- a/tests/unit/builder-nixpacks.bats +++ b/tests/unit/builder-nixpacks.bats @@ -131,6 +131,26 @@ teardown() { assert_output "['task.py', 'some', 'cron', 'task']" } +@test "(builder-nixpacks) core-post-extract renames the configured nixpacks.toml" { + echo "" >"$BATS_TEST_TMPDIR/nixpacks.alt.toml" + + run /bin/bash -c "dokku builder-nixpacks:set $TEST_APP nixpackstoml-path nixpacks.alt.toml" + echo "output: $output" + echo "status: $status" + assert_success + + run_plugin_script builder-nixpacks core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "test -f $BATS_TEST_TMPDIR/nixpacks.toml" + assert_success + + run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/nixpacks.alt.toml" + assert_success +} + cron_run_wrapper() { local APP="$1" local APP_REPO_DIR="$2" diff --git a/tests/unit/builder-pack.bats b/tests/unit/builder-pack.bats index 8e21816af..9cc3a6a05 100644 --- a/tests/unit/builder-pack.bats +++ b/tests/unit/builder-pack.bats @@ -228,6 +228,26 @@ teardown() { assert_output "['task.py', 'test']" } +@test "(builder-pack) core-post-extract renames the configured project.toml" { + echo "" >"$BATS_TEST_TMPDIR/project2.toml" + + run /bin/bash -c "dokku builder-pack:set $TEST_APP projecttoml-path project2.toml" + echo "output: $output" + echo "status: $status" + assert_success + + run_plugin_script builder-pack core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "test -f $BATS_TEST_TMPDIR/project.toml" + assert_success + + run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/project2.toml" + assert_success +} + cron_run_wrapper() { local APP="$1" local APP_REPO_DIR="$2" diff --git a/tests/unit/builder-railpack.bats b/tests/unit/builder-railpack.bats index 133e81542..597283111 100644 --- a/tests/unit/builder-railpack.bats +++ b/tests/unit/builder-railpack.bats @@ -142,6 +142,26 @@ teardown() { assert_output "['task.py', 'some', 'cron', 'task']" } +@test "(builder-railpack) core-post-extract renames the configured railpack.json" { + echo "{}" >"$BATS_TEST_TMPDIR/railpack.alt.json" + + run /bin/bash -c "dokku builder-railpack:set $TEST_APP railpackjson-path railpack.alt.json" + echo "output: $output" + echo "status: $status" + assert_success + + run_plugin_script builder-railpack core-post-extract "$TEST_APP" "$BATS_TEST_TMPDIR" HEAD + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "test -f $BATS_TEST_TMPDIR/railpack.json" + assert_success + + run /bin/bash -c "test ! -e $BATS_TEST_TMPDIR/railpack.alt.json" + assert_success +} + cron_run_wrapper() { local APP="$1" local APP_REPO_DIR="$2" diff --git a/tests/unit/resource_3.bats b/tests/unit/resource_3.bats index 687c1a512..174d2084d 100644 --- a/tests/unit/resource_3.bats +++ b/tests/unit/resource_3.bats @@ -23,7 +23,7 @@ teardown() { echo "status: $status" assert_output "256m" - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT plugn trigger docker-args-process-build $TEST_APP herokuish < /dev/null" + run_plugn_trigger docker-args-process-build "$TEST_APP" herokuish echo "output: $output" echo "status: $status" assert_success @@ -39,7 +39,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT plugn trigger docker-args-process-build $TEST_APP dockerfile < /dev/null" + run_plugn_trigger docker-args-process-build "$TEST_APP" dockerfile echo "output: $output" echo "status: $status" assert_success @@ -55,13 +55,13 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT plugn trigger docker-args-process-build $TEST_APP pack < /dev/null" + run_plugn_trigger docker-args-process-build "$TEST_APP" pack echo "output: $output" echo "status: $status" assert_success assert_output_not_contains "--memory" - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT plugn trigger docker-args-process-build $TEST_APP lambda < /dev/null" + run_plugn_trigger docker-args-process-build "$TEST_APP" lambda echo "output: $output" echo "status: $status" assert_success @@ -74,7 +74,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT plugn trigger docker-args-process-build $TEST_APP herokuish < /dev/null" + run_plugn_trigger docker-args-process-build "$TEST_APP" herokuish echo "output: $output" echo "status: $status" assert_success @@ -87,7 +87,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT plugn trigger docker-args-process-build $TEST_APP herokuish < /dev/null" + run_plugn_trigger docker-args-process-build "$TEST_APP" herokuish echo "output: $output" echo "status: $status" assert_success @@ -101,7 +101,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT DOKKU_OMIT_RESOURCE_ARGS=1 plugn trigger docker-args-process-build $TEST_APP herokuish < /dev/null" + run_plugn_trigger DOKKU_OMIT_RESOURCE_ARGS=1 docker-args-process-build "$TEST_APP" herokuish echo "output: $output" echo "status: $status" assert_success diff --git a/tests/unit/test_helper.bash b/tests/unit/test_helper.bash index 0ad154aea..60ba322e9 100644 --- a/tests/unit/test_helper.bash +++ b/tests/unit/test_helper.bash @@ -231,6 +231,29 @@ destroy_key() { rm -f /tmp/testkey* &>/dev/null || true } +# Run a plugn trigger with the env vars plugn needs, capturing $output/$status via bats `run`. +# Optional VAR=VAL pairs before are forwarded as extra env vars on the bash command line. +# Usage: run_plugn_trigger [VAR=VAL ...] +run_plugn_trigger() { + local extra_env="" + while [[ "$1" == *=* ]]; do + extra_env+=" $1" + shift + done + local TRIGGER="$1" + shift + run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT${extra_env} plugn trigger $TRIGGER $* < /dev/null" +} + +# Run a single plugin's trigger script directly so other plugins' handlers do not fire. +# Captures $output/$status via bats `run`. +# Usage: run_plugin_script +run_plugin_script() { + local PLUGIN_NAME="$1" SCRIPT_NAME="$2" + shift 2 + run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_AVAILABLE_PATH=$PLUGIN_AVAILABLE_PATH PLUGIN_ENABLED_PATH=$PLUGIN_ENABLED_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT $PLUGIN_ENABLED_PATH/$PLUGIN_NAME/$SCRIPT_NAME $*" +} + check_urls() { local PATTERN="$1" run /bin/bash -c "dokku urls $TEST_APP | grep -E \"${PATTERN}\""