From 455a80e09d8ce274a2066e166fdf1659ad5cfb2d Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Tue, 3 Aug 2021 16:23:10 -0400 Subject: [PATCH] chore: drop unimplemented code --- plugins/registry/registry.go | 12 +++++------ plugins/registry/report.go | 42 ++++++++---------------------------- 2 files changed, 14 insertions(+), 40 deletions(-) diff --git a/plugins/registry/registry.go b/plugins/registry/registry.go index 88cf04481..301219437 100644 --- a/plugins/registry/registry.go +++ b/plugins/registry/registry.go @@ -3,16 +3,14 @@ package registry var ( // DefaultProperties is a map of all valid network properties with corresponding default property values DefaultProperties = map[string]string{ - "create-repository": "false", - "image-repo": "", - "push-on-release": "false", - "server": "", + "image-repo": "", + "push-on-release": "false", + "server": "", } // GlobalProperties is a map of all valid global network properties GlobalProperties = map[string]bool{ - "create-repository": true, - "push-on-release": true, - "server": true, + "push-on-release": true, + "server": true, } ) diff --git a/plugins/registry/report.go b/plugins/registry/report.go index 5c38048f6..b02b25ef2 100644 --- a/plugins/registry/report.go +++ b/plugins/registry/report.go @@ -11,18 +11,15 @@ func ReportSingleApp(appName string, format string, infoFlag string) error { } flags := map[string]common.ReportFunc{ - "--registry-computed-create-repository": reportComputedCreateRepository, - "--registry-global-create-repository": reportGlobalCreateRepository, - "--registry-create-repository": reportCreateRepository, - "--registry-computed-image-repo": reportComputedImageRepo, - "--registry-image-repo": reportImageRepo, - "--registry-computed-push-on-release": reportComputedPushOnRelease, - "--registry-global-push-on-release": reportGlobalPushOnRelease, - "--registry-push-on-release": reportPushOnRelease, - "--registry-computed-server": reportComputedServer, - "--registry-global-server": reportGlobalServer, - "--registry-server": reportServer, - "--registry-tag-version": reportTagVersion, + "--registry-computed-image-repo": reportComputedImageRepo, + "--registry-image-repo": reportImageRepo, + "--registry-computed-push-on-release": reportComputedPushOnRelease, + "--registry-global-push-on-release": reportGlobalPushOnRelease, + "--registry-push-on-release": reportPushOnRelease, + "--registry-computed-server": reportComputedServer, + "--registry-global-server": reportGlobalServer, + "--registry-server": reportServer, + "--registry-tag-version": reportTagVersion, } flagKeys := []string{} @@ -36,27 +33,6 @@ func ReportSingleApp(appName string, format string, infoFlag string) error { return common.ReportSingleApp("registry", appName, infoFlag, infoFlags, flagKeys, format, trimPrefix, uppercaseFirstCharacter) } -func reportComputedCreateRepository(appName string) string { - value := reportCreateRepository(appName) - if value == "" { - value = reportGlobalCreateRepository(appName) - } - - if value == "" { - value = DefaultProperties["create-repository"] - } - - return value -} - -func reportGlobalCreateRepository(appName string) string { - return common.PropertyGet("registry", "--global", "create-repository") -} - -func reportCreateRepository(appName string) string { - return common.PropertyGet("registry", appName, "create-repository") -} - func reportComputedImageRepo(appName string) string { imageRepo := reportImageRepo(appName) if imageRepo == "" {