From 7e748a1cf359aebee2d502d57c9acc1adf1a5749 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 14 Sep 2025 05:04:27 -0400 Subject: [PATCH 1/2] fix: do not list folders in Dokku root that start with an upper-case character These were never valid app names, so we can avoid listing them altogether as they aren't Dokku apps. --- plugins/common/common.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/plugins/common/common.go b/plugins/common/common.go index a8ae3e662..4a3d24f7b 100644 --- a/plugins/common/common.go +++ b/plugins/common/common.go @@ -640,6 +640,11 @@ func UnfilteredDokkuApps() ([]string, error) { if strings.HasPrefix(f.Name(), ".") { continue } + // skip apps that start with an uppercase letter + if unicode.IsUpper(rune(f.Name()[0])) { + continue + } + apps = append(apps, f.Name()) } From 1c6927b25ef451d1bca6c54460e9c140f1f90813 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 14 Sep 2025 05:08:23 -0400 Subject: [PATCH 2/2] fix: directly write deployed property The previous method ended up validating the app name when checking if the app was deployed or not, which isn't necessary as that should only be performed at the command-level. --- plugins/common/common.go | 3 +-- plugins/common/triggers.go | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/common/common.go b/plugins/common/common.go index 4a3d24f7b..281ff39a9 100644 --- a/plugins/common/common.go +++ b/plugins/common/common.go @@ -687,8 +687,7 @@ func IsDeployed(appName string) bool { } EnvWrap(func() error { - CommandPropertySet("common", appName, "deployed", deployed, DefaultProperties, GlobalProperties) - return nil + return PropertyWrite("common", appName, "deployed", deployed) }, map[string]string{"DOKKU_QUIET_OUTPUT": "1"}) } diff --git a/plugins/common/triggers.go b/plugins/common/triggers.go index 813a22d45..2c10767da 100644 --- a/plugins/common/triggers.go +++ b/plugins/common/triggers.go @@ -23,8 +23,7 @@ func TriggerAppList(filtered bool) error { // TriggerCorePostDeploy associates the container with a specified network func TriggerCorePostDeploy(appName string) error { return EnvWrap(func() error { - CommandPropertySet("common", appName, "deployed", "true", DefaultProperties, GlobalProperties) - return nil + return PropertyWrite("common", appName, "deployed", "true") }, map[string]string{"DOKKU_QUIET_OUTPUT": "1"}) }