feat: add scheduler-k3s:charts:set and :charts:report

Helm chart overrides on the scheduler-k3s plugin were previously set
through the generic `scheduler-k3s:set --global chart.<chart>.<property>`
interface, which mixed chart-level configuration into the same command
that manages scheduler properties and offered no focused way to inspect
which overrides were configured. A dedicated `scheduler-k3s:charts:set`
sets and clears chart-specific helm values, and a complementary
`scheduler-k3s:charts:report` surfaces configured overrides per chart
with optional JSON output and single-field flag queries. The legacy form
on `scheduler-k3s:set` continues to work but now emits a deprecation
warning pointing users at the new subcommand.

plugins/scheduler-k3s/Makefile

@@ -1,4 +1,4 @@
-SUBCOMMANDS = subcommands/annotations:set subcommands/autoscaling-auth:set subcommands/autoscaling-auth:report subcommands/cluster:add subcommands/cluster:list subcommands/cluster:remove subcommands/ensure-charts subcommands/initialize subcommands/labels:set subcommands/profiles:add subcommands/profiles:list subcommands/profiles:remove subcommands/report subcommands/set subcommands/show-kubeconfig subcommands/uninstall
+SUBCOMMANDS = subcommands/annotations:set subcommands/autoscaling-auth:set subcommands/autoscaling-auth:report subcommands/charts:report subcommands/charts:set subcommands/cluster:add subcommands/cluster:list subcommands/cluster:remove subcommands/ensure-charts subcommands/initialize subcommands/labels:set subcommands/profiles:add subcommands/profiles:list subcommands/profiles:remove subcommands/report subcommands/set subcommands/show-kubeconfig subcommands/uninstall
 TRIGGERS = triggers/core-post-deploy triggers/core-post-extract triggers/install triggers/post-app-clone-setup triggers/post-app-rename-setup triggers/post-certs-update triggers/post-certs-remove triggers/post-create triggers/post-delete triggers/report triggers/scheduler-app-status triggers/scheduler-deploy triggers/scheduler-enter triggers/scheduler-is-deployed triggers/scheduler-logs triggers/scheduler-proxy-config triggers/scheduler-proxy-logs triggers/scheduler-post-delete triggers/scheduler-run triggers/scheduler-run-list triggers/scheduler-stop triggers/scheduler-cron-write triggers/storage-create triggers/storage-destroy triggers/storage-status triggers/scheduler-storage-exec
 BUILD = commands subcommands triggers
 PLUGIN_NAME = scheduler-k3s

plugins/scheduler-k3s/src/commands/commands.go

@@ -19,6 +19,8 @@ Additional commands:`
 	helpContent = `
     scheduler-k3s:autoscaling-auth:set <app|--global> <trigger> [<--metadata key=value>...], Set or clear a scheduler-k3s autoscaling keda trigger authentication resource for an app
     scheduler-k3s:annotations:set <app|--global> <property> (<value>) [--process-type PROCESS_TYPE] <--resource-type RESOURCE_TYPE>, Set or clear an annotation for a given app/process-type/resource-type combination
+    scheduler-k3s:charts:report [<chart>] [--format stdout|json], Displays a scheduler-k3s chart override report
+    scheduler-k3s:charts:set <chart-name.property> (<value>), Set or clear a chart-specific helm value
     scheduler-k3s:cluster:add [--profile PROFILE] [--role ROLE] [--insecure-allow-unknown-hosts] [--server-ip SERVER_IP] [--taint-scheduling] [--kubelet-args KUBELET_ARGS] <ssh://user@host:port>, Adds a server node to a Dokku-managed cluster
     scheduler-k3s:cluster:list [--format json|stdout], Lists all nodes in a Dokku-managed cluster
     scheduler-k3s:cluster:remove [node-id], Removes client node to a Dokku-managed cluster

plugins/scheduler-k3s/src/subcommands/subcommands.go

@@ -54,6 +54,23 @@ func main() {
 		args.Parse(os.Args[2:])
 		appName := args.Arg(0)
 		err = scheduler_k3s.CommandAutoscalingAuthReport(appName, *format, *global, *includeMetadata)
+	case "charts:set":
+		args := flag.NewFlagSet("scheduler-k3s:charts:set", flag.ExitOnError)
+		args.Parse(os.Args[2:])
+		property := args.Arg(0)
+		value := args.Arg(1)
+		err = scheduler_k3s.CommandChartsSet(property, value)
+	case "charts:report":
+		args := flag.NewFlagSet("scheduler-k3s:charts:report", flag.ExitOnError)
+		format := args.String("format", "stdout", "format: [ stdout | json ]")
+		reportArgs, flagErr := common.ParseReportArgs("scheduler-k3s-charts", os.Args[2:])
+		if flagErr == nil {
+			args.Parse(reportArgs.OSArgs)
+			chartName := args.Arg(0)
+			err = scheduler_k3s.CommandChartsReport(chartName, *format, reportArgs.InfoFlag)
+		} else {
+			err = flagErr
+		}
 	case "cluster:add":
 		args := flag.NewFlagSet("scheduler-k3s:cluster:add", flag.ExitOnError)
 		allowUknownHosts := args.Bool("insecure-allow-unknown-hosts", false, "insecure-allow-unknown-hosts: allow unknown hosts")

plugins/scheduler-k3s/subcommands.go

@@ -400,6 +400,153 @@ func CommandInitialize(ingressClass string, serverIP string, taintScheduling boo
 	return nil
 }
 
+// CommandChartsSet sets or clears a chart-specific helm value for the scheduler
+func CommandChartsSet(propertyArg string, value string) error {
+	if propertyArg == "" {
+		return fmt.Errorf("Invalid property, expected format: <chart-name>.<property>")
+	}
+
+	dotIndex := strings.Index(propertyArg, ".")
+	if dotIndex <= 0 || dotIndex == len(propertyArg)-1 {
+		return fmt.Errorf("Invalid property, expected format: <chart-name>.<property>")
+	}
+
+	chartName := propertyArg[:dotIndex]
+	chartProperty := propertyArg[dotIndex+1:]
+
+	knownCharts := []string{}
+	chartFound := false
+	for _, chart := range HelmCharts {
+		knownCharts = append(knownCharts, chart.ReleaseName)
+		if chart.ReleaseName == chartName {
+			chartFound = true
+		}
+	}
+	if !chartFound {
+		sort.Strings(knownCharts)
+		return fmt.Errorf("Invalid chart name %q, valid charts: %s", chartName, strings.Join(knownCharts, ", "))
+	}
+
+	key := fmt.Sprintf("chart.%s.%s", chartName, chartProperty)
+	if value != "" {
+		common.LogInfo2Quiet(fmt.Sprintf("Setting %s to %s", key, value))
+		if err := common.PropertyWrite("scheduler-k3s", "--global", key, value); err != nil {
+			return fmt.Errorf("Unable to write property: %w", err)
+		}
+		return nil
+	}
+
+	common.LogInfo2Quiet(fmt.Sprintf("Unsetting %s", key))
+	if err := common.PropertyDelete("scheduler-k3s", "--global", key); err != nil {
+		return fmt.Errorf("Unable to delete property: %w", err)
+	}
+	return nil
+}
+
+// CommandChartsReport displays a scheduler-k3s chart override report
+func CommandChartsReport(chartName string, format string, infoFlag string) error {
+	if format != "stdout" && format != "json" {
+		return fmt.Errorf("Invalid format: %s", format)
+	}
+
+	if format == "json" && infoFlag != "" {
+		return fmt.Errorf("--format flag cannot be specified when specifying an info flag")
+	}
+
+	charts := []HelmChart{}
+	if chartName != "" {
+		found := false
+		for _, chart := range HelmCharts {
+			if chart.ReleaseName == chartName {
+				charts = append(charts, chart)
+				found = true
+				break
+			}
+		}
+		if !found {
+			knownCharts := []string{}
+			for _, chart := range HelmCharts {
+				knownCharts = append(knownCharts, chart.ReleaseName)
+			}
+			sort.Strings(knownCharts)
+			return fmt.Errorf("Invalid chart name %q, valid charts: %s", chartName, strings.Join(knownCharts, ", "))
+		}
+	} else {
+		charts = append(charts, HelmCharts...)
+	}
+
+	overridesByChart := map[string]map[string]string{}
+	flatOverrides := map[string]string{}
+	flagToValue := map[string]string{}
+	for _, chart := range charts {
+		properties, err := common.PropertyGetAllByPrefix("scheduler-k3s", "--global", "chart."+chart.ReleaseName+".")
+		if err != nil {
+			return fmt.Errorf("Unable to get chart properties: %w", err)
+		}
+
+		chartOverrides := map[string]string{}
+		prefix := "chart." + chart.ReleaseName + "."
+		for key, value := range properties {
+			overrideKey := strings.TrimPrefix(key, prefix)
+			chartOverrides[overrideKey] = value
+			flatKey := chart.ReleaseName + "." + overrideKey
+			flatOverrides[flatKey] = value
+			flagToValue["--scheduler-k3s-charts-"+flatKey] = value
+		}
+		overridesByChart[chart.ReleaseName] = chartOverrides
+	}
+
+	if infoFlag != "" {
+		value, ok := flagToValue[infoFlag]
+		if !ok {
+			validFlags := []string{}
+			for flag := range flagToValue {
+				validFlags = append(validFlags, flag)
+			}
+			sort.Strings(validFlags)
+			return fmt.Errorf("Invalid flag passed, valid flags: %s", strings.Join(validFlags, ", "))
+		}
+		fmt.Println(value)
+		return nil
+	}
+
+	if format == "json" {
+		b, err := json.Marshal(flatOverrides)
+		if err != nil {
+			return fmt.Errorf("Unable to marshal json: %w", err)
+		}
+		fmt.Println(string(b))
+		return nil
+	}
+
+	length := 31
+	for _, overrides := range overridesByChart {
+		for key := range overrides {
+			label := fmt.Sprintf("Chart property %s:", key)
+			if len(label) > length {
+				length = len(label)
+			}
+		}
+	}
+
+	for _, chart := range charts {
+		common.LogInfo2Quiet(fmt.Sprintf("%s chart information", chart.ReleaseName))
+
+		overrideKeys := []string{}
+		for key := range overridesByChart[chart.ReleaseName] {
+			overrideKeys = append(overrideKeys, key)
+		}
+		sort.Strings(overrideKeys)
+
+		for _, key := range overrideKeys {
+			label := fmt.Sprintf("Chart property %s:", key)
+			common.LogVerbose(fmt.Sprintf("%s%s", common.RightPad(label, length, " "), overridesByChart[chart.ReleaseName][key]))
+		}
+	}
+
+	return nil
+}
+
 // CommandClusterAdd adds a server to the k3s cluster
 func CommandClusterAdd(profileName string, role string, remoteHost string, serverIP string, allowUknownHosts bool, taintScheduling bool, kubeletArgs []string) error {
 	if err := isK3sInstalled(); err != nil {
@@ -1166,6 +1313,8 @@ func CommandSet(appName string, property string, value string) error {
 	validProperties := DefaultProperties
 	globalProperties := GlobalProperties
 	if strings.HasPrefix(property, "chart.") {
+		common.LogWarn("scheduler-k3s:set chart.* properties are deprecated; use scheduler-k3s:charts:set <chart>.<property> instead")
+
 		if appName != "--global" {
 			return fmt.Errorf("Chart properties can only be set globally")
 		}