github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #5051 from dokku/5044-sluggify-vector

Browse Source 
Ensure vector component sources have valid names
This commit is contained in:
Jose Diaz-Gonzalez
2022-02-27 19:18:15 -05:00
committed by GitHub
parent 860f4f458c 2a02aa0b9b
commit 39aa42440b
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/logs/functions.go
View File

@@ -167,6 +167,7 @@ func writeVectorConfig() error {
continue continue
} }
appName = strings.ReplaceAll(appName, ".", "-")
sink, err := sinkValueToConfig(appName, value) sink, err := sinkValueToConfig(appName, value)
if err != nil { if err != nil {
return err return err

10
tests/unit/logs.bats
View File

@@ -522,6 +522,11 @@ teardown() {
assert_failure assert_failure
assert_output_contains "Vector container does not exist" assert_output_contains "Vector container does not exist"
run /bin/bash -c "dokku apps:create example.com"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku logs:vector-start 2>&1" run /bin/bash -c "dokku logs:vector-start 2>&1"
echo "output: $output" echo "output: $output"
echo "status: $status" echo "status: $status"
@@ -534,6 +539,11 @@ teardown() {
assert_success assert_success
assert_output_contains "Vector container logs" assert_output_contains "Vector container logs"
run /bin/bash -c "dokku --force apps:destroy example.com"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku logs:vector-logs --num 10 2>&1" run /bin/bash -c "dokku logs:vector-logs --num 10 2>&1"
echo "output: $output" echo "output: $output"
echo "status: $status" echo "status: $status"