From babb2766bd5a1592f3fb67e3cd55db5596d9d4e2 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 29 Dec 2022 00:02:24 -0500 Subject: [PATCH 1/9] chore: update publish-unit-test-result-action --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2664b120d..ceedd3e0a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -163,9 +163,9 @@ jobs: path: test-results - name: Publish Unit Test Results - uses: docker://ghcr.io/enricomi/publish-unit-test-result-action:v1 + uses: EnricoMi/publish-unit-test-result-action@v2 with: check_name: Unit Test Results github_token: ${{ secrets.GITHUB_TOKEN }} - files: test-results/**/*.xml - comment_on_pr: false + junit_files: test-results/**/*.xml + comment_mode: off From c082b68b236f0cecd9f4116848de9776b47e56ab Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 29 Dec 2022 00:03:07 -0500 Subject: [PATCH 2/9] chore: update actions/download-artifact --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ceedd3e0a..b55dd85e8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: - uses: actions/checkout@v3 - name: download packages - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v3 with: name: build @@ -95,7 +95,7 @@ jobs: - uses: actions/checkout@v3 - name: download packages - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v3 with: name: build @@ -124,7 +124,7 @@ jobs: - uses: actions/checkout@v3 - name: download packages - uses: actions/download-artifact@v1 + uses: actions/download-artifact@v3 with: name: build @@ -158,7 +158,7 @@ jobs: steps: - name: download test-results - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: path: test-results From c8ec0825d38d4207f748e777a390937672688128 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 29 Dec 2022 00:05:02 -0500 Subject: [PATCH 3/9] chore: update actions/checkout --- .github/workflows/docs.yml | 2 +- docs/deployment/continuous-integration/github-actions.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index b4892776e..719c381fc 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Cloning repo - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 diff --git a/docs/deployment/continuous-integration/github-actions.md b/docs/deployment/continuous-integration/github-actions.md index cb3cd5640..bae3ca1dc 100644 --- a/docs/deployment/continuous-integration/github-actions.md +++ b/docs/deployment/continuous-integration/github-actions.md @@ -16,7 +16,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Cloning repo - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 From 9e2c151e9f4fc870077c762b0d584dee266efddd Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 29 Dec 2022 00:10:47 -0500 Subject: [PATCH 4/9] chore: update workflows in lint.yml --- .github/workflows/lint.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index e8e10df2c..1189be3b2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -19,7 +19,7 @@ jobs: uses: actions/checkout@v3 - name: Run hadolint uses: hadolint/hadolint-action@4b5806eb9c6bee4954fc0e0cc3ad6175fc9782c1 - # v1.6.0 => d7b38582334d9ac11c12021c16f21d63015fa250 + # v3.0.0 => 4b5806eb9c6bee4954fc0e0cc3ad6175fc9782c1 markdown-lint: name: markdown-lint @@ -55,7 +55,7 @@ jobs: uses: actions/checkout@v3 - name: Run shfmt uses: luizm/action-sh-checker@edd0e45ecff35b05f162052b50df50976c1b74fc - # v0.3.0 => 7f44869033b40ee4ffe7dc76c87a1bc66e3d025a + # v0.5.0 => edd0e45ecff35b05f162052b50df50976c1b74fc env: SHFMT_OPTS: -l -bn -ci -i 2 -d with: @@ -69,6 +69,6 @@ jobs: uses: actions/checkout@v3 - name: Run yamllint uses: ibiqlik/action-yamllint@2576378a8e339169678f9939646ee3ee325e845c - # v3.0.4 => ed2b6e911569708ed121c14b87d513860a7e36a7 + # v3.1.1 => 2576378a8e339169678f9939646ee3ee325e845c with: config_file: '.github/linters/.yamllint.yml' From 6e28b9f835de378cc6c34934d56ce3a6483008e0 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 29 Dec 2022 00:14:29 -0500 Subject: [PATCH 5/9] chore: drop set-output usage --- .github/workflows/ci.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b55dd85e8..1d4ad64a4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -37,7 +37,7 @@ jobs: run: | json=$(python .github/commands/matrix) echo $json - echo "::set-output name=matrix::$(echo "$json")" + echo "matrix=$json" >> $GITHUB_OUTPUT - name: upload packages uses: actions/upload-artifact@v3 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index aae9416bc..24b7458d5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -61,7 +61,7 @@ jobs: - name: output version id: version - run: echo "::set-output name=version::$(cat build/next-version)" + run: echo "version=$(cat build/next-version)" >> $GITHUB_OUTPUT - name: upload packages uses: actions/upload-artifact@v3 From 9f1bfb0d06199687d720e7cb61910a9cb6706beb Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 29 Dec 2022 01:52:33 -0500 Subject: [PATCH 6/9] fix: set path to ensure compatibility with v1 of the action See https://github.com/actions/download-artifact#compatibility-between-v1-and-v2v3 for more details. --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d4ad64a4..505dbe359 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,6 +60,7 @@ jobs: uses: actions/download-artifact@v3 with: name: build + path: build - name: ci-setup run: ./.github/commands/ci-setup @@ -98,6 +99,7 @@ jobs: uses: actions/download-artifact@v3 with: name: build + path: build - name: ci-setup run: ./.github/commands/ci-setup @@ -127,6 +129,7 @@ jobs: uses: actions/download-artifact@v3 with: name: build + path: build - name: ci-setup run: ./.github/commands/ci-setup @@ -161,6 +164,7 @@ jobs: uses: actions/download-artifact@v3 with: path: test-results + path: test-results - name: Publish Unit Test Results uses: EnricoMi/publish-unit-test-result-action@v2 From 0657e3a1f13f67689f05fd1f08850cddbc564d97 Mon Sep 17 00:00:00 2001 From: josegonzalez Date: Thu, 29 Dec 2022 10:22:04 -0500 Subject: [PATCH 7/9] fix: correct yaml lint issues --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 505dbe359..b7f9245d0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -163,7 +163,7 @@ jobs: - name: download test-results uses: actions/download-artifact@v3 with: - path: test-results + name: test-results path: test-results - name: Publish Unit Test Results @@ -172,4 +172,4 @@ jobs: check_name: Unit Test Results github_token: ${{ secrets.GITHUB_TOKEN }} junit_files: test-results/**/*.xml - comment_mode: off + comment_mode: false From 20c30dc5875c687f7c563d698709497a96330340 Mon Sep 17 00:00:00 2001 From: josegonzalez Date: Thu, 29 Dec 2022 11:32:20 -0500 Subject: [PATCH 8/9] fix: drop name so all test results are downloaded --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b7f9245d0..9572ed0eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -163,7 +163,6 @@ jobs: - name: download test-results uses: actions/download-artifact@v3 with: - name: test-results path: test-results - name: Publish Unit Test Results From 8d17d142a88e9ec18e9481419508feddb034ed13 Mon Sep 17 00:00:00 2001 From: josegonzalez Date: Sun, 8 Jan 2023 20:18:33 -0500 Subject: [PATCH 9/9] fix: use correct value for comment_mode --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9572ed0eb..30bbee4ca 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -171,4 +171,4 @@ jobs: check_name: Unit Test Results github_token: ${{ secrets.GITHUB_TOKEN }} junit_files: test-results/**/*.xml - comment_mode: false + comment_mode: "off"