From 23bcb4127ae5e066cbfbdf8c694237df79e48dd9 Mon Sep 17 00:00:00 2001 From: buckle2000 Date: Sat, 23 Sep 2017 14:53:35 +0800 Subject: [PATCH 1/2] Update application-deployment.md Well, please add a yellow "warning" background to the added backquote. --- docs/deployment/application-deployment.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/deployment/application-deployment.md b/docs/deployment/application-deployment.md index 8bb6aa1c7..c0054ada8 100644 --- a/docs/deployment/application-deployment.md +++ b/docs/deployment/application-deployment.md @@ -59,6 +59,11 @@ git remote add dokku dokku@dokku.me:ruby-rails-sample git push dokku master ``` +> Please note that the string `dokku@dokku.me:ruby-rails-sample` here is not a URL. +> It is [a scp-like syntax supported in Git](https://git-scm.com/docs/git-clone#_git_urls_a_id_urls_a). +> You may want to replace it with the full URL `ssh://dokku@dokku.me/ruby-rails-sample` in practice. + + ``` Counting objects: 231, done. Delta compression using up to 8 threads. From 2278290b91736f13bd0e96b4d83724c3151e7eea Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sat, 23 Sep 2017 02:58:25 -0400 Subject: [PATCH 2/2] docs: reword note. [ci skip] --- docs/deployment/application-deployment.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/deployment/application-deployment.md b/docs/deployment/application-deployment.md index c0054ada8..bcad98b44 100644 --- a/docs/deployment/application-deployment.md +++ b/docs/deployment/application-deployment.md @@ -59,10 +59,9 @@ git remote add dokku dokku@dokku.me:ruby-rails-sample git push dokku master ``` -> Please note that the string `dokku@dokku.me:ruby-rails-sample` here is not a URL. -> It is [a scp-like syntax supported in Git](https://git-scm.com/docs/git-clone#_git_urls_a_id_urls_a). -> You may want to replace it with the full URL `ssh://dokku@dokku.me/ruby-rails-sample` in practice. - +> Note: Some tools may not support the short-upstream syntax referenced above, and you may need to prefix +> the upstream with the scheme `ssh://` like so: `ssh://dokku@dokku.me/ruby-rails-sample` +> Please see the [Git](https://git-scm.com/docs/git-clone#_git_urls_a_id_urls_a) documentation for more details. ``` Counting objects: 231, done.