github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: run crontab under sudo to support rhel systems

Browse Source 
RHEL blocks users from executing crontab as themselves Because Of Reasons so we need to use sudo instead.

Also refactors file writing to properly support writing the permissions on sudoers files going forward.

Closes #5020
This commit is contained in:
Jose Diaz-Gonzalez
2022-02-27 19:17:04 -05:00
parent 2e1df2578c
commit 257baa1d46
8 changed files with 56 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/cron/functions.go
View File

@@ -81,13 +81,13 @@ func fetchCronEntries(appName string) ([]templateCommand, error) {
}
func deleteCrontab() error {
command := common.NewShellCmd("crontab -l -u dokku")
command := common.NewShellCmd("sudo /usr/bin/crontab -l -u dokku")
command.ShowOutput = false
if !command.Execute() {
return nil
}
command = common.NewShellCmd("crontab -r -u dokku")
command = common.NewShellCmd("sudo /usr/bin/crontab -r -u dokku")
command.ShowOutput = false
out, err := command.CombinedOutput()
if err != nil {
@@ -163,7 +163,7 @@ func writeCronEntries() error {
return fmt.Errorf("Unable to template out schedule file: %v", err)
}
command := common.NewShellCmd(fmt.Sprintf("crontab -u dokku %s", tmpFile.Name()))
command := common.NewShellCmd(fmt.Sprintf("sudo /usr/bin/crontab -u dokku %s", tmpFile.Name()))
command.ShowOutput = false
out, err := command.CombinedOutput()
if err != nil {