fix: fail deploy tasks when a docker-args trigger fails
The ephemeral containers that run `app.json` deploy tasks ignored a failure from the `docker-args-deploy` and `docker-args-process-deploy` triggers, so a plugin refusing to describe the container produced a task that ran without the arguments it had asked for, while the very same failure aborted the deploy moments later on the scheduler's own path. Both are now fatal, which the trigger documentation states. Storage no longer reports a scheduler mismatch for an app deploying with another scheduler, since those triggers are fired for every app whatever its scheduler and a k3s app's volumes are mounted by k3s rather than bound into a container here.
This commit is contained in:
5 files changed
+70
-15
No files matched your search
@@ -20,6 +20,10 @@ func withTempLibRoot(t *testing.T) string {
|
||||
t.Helper()
|
||||
dir := t.TempDir()
|
||||
t.Setenv("DOKKU_LIB_ROOT", dir)
|
||||
// Point plugn at an empty tree so anything resolving a plugin trigger in
|
||||
// these tests falls back to its default instead of reading the host's
|
||||
// real dokku install.
|
||||
t.Setenv("PLUGIN_PATH", filepath.Join(dir, "plugins"))
|
||||
|
||||
current, err := user.Current()
|
||||
if err != nil {
|
||||
|
||||
Reference in new issue
Block a user