feat: send SIGTERM to old containers immediately on deploy

The docker-local scheduler now sends `SIGTERM` to old containers immediately after a successful deploy via `docker container kill --signal=SIGTERM`, rather than waiting `wait-to-retire` seconds before signaling. This matches Heroku's graceful-shutdown contract and lets applications begin draining in-flight work as soon as proxy traffic switches. The existing `wait-to-retire` grace period and `stop-timeout-seconds` hard-stop continue to apply unchanged as the authoritative cleanup path.
This commit is contained in:
Jose Diaz-Gonzalez
2026-04-27 18:18:39 -04:00
parent f19227dcd9
commit 1161dda05e
4 changed files with 55 additions and 1 deletions

View File

@@ -176,6 +176,44 @@ teardown() {
assert_output_contains "Deploys may fail when publishing ports and enabling zero downtime" 0
}
@test "(scheduler-docker-local) sends SIGTERM immediately on deploy" {
run create_app
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku checks:set $TEST_APP wait-to-retire 600"
echo "output: $output"
echo "status: $status"
assert_success
run deploy_app
echo "output: $output"
echo "status: $status"
assert_success
local old_cid
old_cid="$(docker ps --filter label=com.dokku.app-name=$TEST_APP --filter label=com.dokku.process-type=web --format '{{.ID}}')"
[[ -n "$old_cid" ]]
run /bin/bash -c "dokku ps:rebuild $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
sleep 5
run /bin/bash -c "docker inspect --format '{{.State.Status}}' $old_cid"
echo "output: $output"
echo "status: $status"
assert_output "exited"
run /bin/bash -c "docker ps --filter label=com.dokku.app-name=$TEST_APP --filter label=com.dokku.process-type=web --format '{{.Names}}'"
echo "output: $output"
echo "status: $status"
assert_output "$TEST_APP.web.1"
}
@test "(scheduler-docker-local) scale down retires orphaned containers" {
run create_app
echo "output: $output"