From 57bbe917b0c2bfa0b11c0c80beb35984064d8844 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 20 Sep 2026 02:53:32 -0400 Subject: [PATCH] fix: call the datastore create command the way it is documented The ports and app-json tests passed the app name to `postgres:create` and `redis:create` a second time, as a positional the command has never taken. The bash datastore plugins parsed their arguments with getopts and simply stopped at it; those plugins now dispatch to a binary that reports the count instead, so every dokku pull request fails on `This command requires 2 arguments, 3 arguments given`. The documented form takes the service alone, as `docs/deployment/application-deployment.md` shows. The `:link` and `:unlink` calls beside these are unchanged, since those do take two. --- tests/unit/app-json.bats | 4 ++-- tests/unit/ports.bats | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/unit/app-json.bats b/tests/unit/app-json.bats index b9bb6f8bf..775ecda8f 100644 --- a/tests/unit/app-json.bats +++ b/tests/unit/app-json.bats @@ -144,7 +144,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "dokku postgres:create $TEST_APP $TEST_APP" + run /bin/bash -c "dokku postgres:create $TEST_APP" echo "output: $output" echo "status: $status" assert_success @@ -154,7 +154,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "dokku redis:create $TEST_APP $TEST_APP" + run /bin/bash -c "dokku redis:create $TEST_APP" echo "output: $output" echo "status: $status" assert_success diff --git a/tests/unit/ports.bats b/tests/unit/ports.bats index e09440b60..a79395464 100644 --- a/tests/unit/ports.bats +++ b/tests/unit/ports.bats @@ -274,7 +274,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "dokku postgres:create $TEST_APP $TEST_APP" + run /bin/bash -c "dokku postgres:create $TEST_APP" echo "output: $output" echo "status: $status" assert_success @@ -284,7 +284,7 @@ teardown() { echo "status: $status" assert_success - run /bin/bash -c "dokku redis:create $TEST_APP $TEST_APP" + run /bin/bash -c "dokku redis:create $TEST_APP" echo "output: $output" echo "status: $status" assert_success