github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

docs: fix GitLab CI examples

Browse Source 
The GitLab CI examples used `$CI_ENVIRONMENT_SLUG` for defining the environment names
of the deploy jobs. But this variable is actually the OUTPUT of setting the environment name,
thus, it tries to reference itself, but does not exist in that moment.

The correct way to set this is to use `$CI_COMMIT_REF_NAME` as based on the documentation
of GitLab's dynamic environments.
This commit is contained in:
René Stalder
2019-04-18 18:06:52 +02:00
committed by GitHub
parent dbc5182193
commit 06b4585a62
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/community/tutorials/deploying-with-gitlab-ci.md
View File

@@ -65,7 +65,7 @@ review_app:
image: ilyasemenov/gitlab-ci-git-push image: ilyasemenov/gitlab-ci-git-push
stage: deploy stage: deploy
environment: environment:
name: review/$CI_ENVIRONMENT_SLUG name: review/$CI_COMMIT_REF_NAME
url: https://$CI_ENVIRONMENT_SLUG.dokku.me/ url: https://$CI_ENVIRONMENT_SLUG.dokku.me/
on_stop: stop_review_app on_stop: stop_review_app
only: only:
@@ -88,7 +88,7 @@ stop_review_app:
image: ilyasemenov/gitlab-ci-git-push image: ilyasemenov/gitlab-ci-git-push
stage: deploy stage: deploy
environment: environment:
name: review/$CI_ENVIRONMENT_SLUG name: review/$CI_COMMIT_REF_NAME
action: stop action: stop
when: manual when: manual
script: script: