github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: unset bind-all-interfaces on empty value

Browse Source 
`dokku network:set --global bind-all-interfaces` (no value) wrote the literal string `false` to the property file instead of unsetting it, so external tooling could not distinguish "explicitly set to default" from "not set". Drop the empty-to-`false` coercion in `CommandSet` so the empty-value path reaches `PropertyDelete` like every other property, and remove the unconditional `TriggerPostCreate` write so new apps consult the global value before falling back to the `"false"` computed default.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-27 05:13:25 -04:00
parent a3538bbb66
commit 035c021485
5 changed files with 94 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/network/triggers.go
View File

@@ -222,16 +222,6 @@ func TriggerPostContainerCreate(containerType string, containerID string, appNam
return nil
}
// TriggerPostCreate sets bind-all-interfaces to false by default
func TriggerPostCreate(appName string) error {
err := common.PropertyWrite("network", appName, "bind-all-interfaces", "false")
if err != nil {
common.LogWarn(err.Error())
}
return nil
}
// TriggerPostDelete destroys the network property for a given app container
func TriggerPostDelete(appName string) error {
return common.PropertyDestroy("network", appName)