github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: unset bind-all-interfaces on empty value

Browse Source 
`dokku network:set --global bind-all-interfaces` (no value) wrote the literal string `false` to the property file instead of unsetting it, so external tooling could not distinguish "explicitly set to default" from "not set". Drop the empty-to-`false` coercion in `CommandSet` so the empty-value path reaches `PropertyDelete` like every other property, and remove the unconditional `TriggerPostCreate` write so new apps consult the global value before falling back to the `"false"` computed default.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-27 05:13:25 -04:00
parent a3538bbb66
commit 035c021485
5 changed files with 94 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/network/Makefile
View File

@@ -1,5 +1,5 @@
SUBCOMMANDS = subcommands/create subcommands/destroy subcommands/exists subcommands/info subcommands/list subcommands/rebuild subcommands/rebuildall subcommands/report subcommands/set
TRIGGERS = triggers/core-post-deploy triggers/docker-args-process-build triggers/docker-args-process-deploy triggers/docker-args-process-run triggers/install triggers/network-build-config triggers/network-config-exists triggers/network-get-ipaddr triggers/network-get-listeners triggers/network-get-property triggers/network-get-static-listeners triggers/network-write-ipaddr triggers/network-write-port triggers/post-app-clone-setup triggers/post-app-rename-setup triggers/post-container-create triggers/post-create triggers/post-delete triggers/report
TRIGGERS = triggers/core-post-deploy triggers/docker-args-process-build triggers/docker-args-process-deploy triggers/docker-args-process-run triggers/install triggers/network-build-config triggers/network-config-exists triggers/network-get-ipaddr triggers/network-get-listeners triggers/network-get-property triggers/network-get-static-listeners triggers/network-write-ipaddr triggers/network-write-port triggers/post-app-clone-setup triggers/post-app-rename-setup triggers/post-container-create triggers/post-delete triggers/report
BUILD = commands subcommands triggers
PLUGIN_NAME = network

3
plugins/network/src/triggers/triggers.go
View File

@@ -82,9 +82,6 @@ func main() {
phase := flag.Arg(3)
processType := flag.Arg(4)
err = network.TriggerPostContainerCreate(containerType, containerID, appName, phase, processType)
case "post-create":
appName := flag.Arg(0)
err = network.TriggerPostCreate(appName)
case "post-delete":
appName := flag.Arg(0)
err = network.TriggerPostDelete(appName)

4
plugins/network/subcommands.go
View File

@@ -192,10 +192,6 @@ func CommandSet(appName string, property string, value string, values []string)
}
}
if property == "bind-all-interfaces" && value == "" {
value = "false"
}
attachProperties := map[string]bool{
"attach-post-create": true,
"attach-post-deploy": true,

10
plugins/network/triggers.go
View File

@@ -222,16 +222,6 @@ func TriggerPostContainerCreate(containerType string, containerID string, appNam
return nil
}
// TriggerPostCreate sets bind-all-interfaces to false by default
func TriggerPostCreate(appName string) error {
err := common.PropertyWrite("network", appName, "bind-all-interfaces", "false")
if err != nil {
common.LogWarn(err.Error())
}
return nil
}
// TriggerPostDelete destroys the network property for a given app container
func TriggerPostDelete(appName string) error {
return common.PropertyDestroy("network", appName)